[eq-dev] vmmlib's matrix pre_rotate_x and pre_rotate_y probably swapped

Andreas Kirsch (in.tum) kirschan at in.tum.de
Thu Sep 17 10:54:03 CEST 2009


Hello,

if you look at http://blackhc.pastebin.com/d7a6e4443 (pre_rotate_x and 
pre_rotate_y's code in matrix.hpp). You'll notice that pre_rotate_x 
changes the x and z components of the column vectors and pre_rotate_y 
change the y and z components of the column vectors.
I think the two functions are misnamed, the names should be swapped.
I have not checked for any sign issues, but certainly there is something 
wrong since any rotation around the x axis shouldn't change the x 
component of the rotated vector (same thing for the y axis and y component).

Cheers,
 Andreas



More information about the eq-dev mailing list